How to make a good index

The American Society for Indexing has an excellent page giving advice on how to make and evaluate a good index.

See: Index evaluation and Advice for editors and authors